Fix #14607: MISRA: make rule 10.3 warn on bool <- 0/1 in C99 and later#8340
Open
varshneydevansh wants to merge 1 commit intodanmar:mainfrom
Open
Fix #14607: MISRA: make rule 10.3 warn on bool <- 0/1 in C99 and later#8340varshneydevansh wants to merge 1 commit intodanmar:mainfrom
varshneydevansh wants to merge 1 commit intodanmar:mainfrom
Conversation
Author
|
Trac ticket is now filed: https://trac.cppcheck.net/ticket/14607 Local verification passed:
|
|
varshneydevansh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #14607.
This updates MISRA rule 10.3 in
addons/misra.pyso that assignments of integer literals0and1toboolare only exempted in C89.Behavior after this change:
bool <- 0/1bool <- 0/1The motivation is that in C99 and later,
bool/true/falseare available, so the current unconditional exemption for0and1causes a MISRA 10.3 false negative.Changes:
addons/misra.pyrule 10.3 to make thebool <- 0/1exemption standard-dependentaddons/test/misra/misra-test.caddons/test/misra/misra-test-c11.cRelated Context: